abci++: plumb vote extension methods into interface#9532
Closed
cmwaters wants to merge 46 commits intofeature/abci++veffrom
Closed
abci++: plumb vote extension methods into interface#9532cmwaters wants to merge 46 commits intofeature/abci++veffrom
cmwaters wants to merge 46 commits intofeature/abci++veffrom
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
3 tasks
|
@cmwaters could you rebase this with cal/finalize-block so that your protobuf changes from that PR are reflected here? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
Closing this PR to consolidate it with #9620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does all the initial plumage, adding the required methods to the interface without actually calling them in any situations.
This is predominantly from #8031 but also refers to prior work #6646 and #6885
NOTE: This builds on top of the finalize-block work