Skip to content

ci: Remove "(WARNING: BETA SOFTWARE)" tagline from all upcoming releases (backport #9371)#9373

Merged
thanethomson merged 3 commits intov0.34.xfrom
mergify/bp/v0.34.x/pr-9371
Sep 5, 2022
Merged

ci: Remove "(WARNING: BETA SOFTWARE)" tagline from all upcoming releases (backport #9371)#9373
thanethomson merged 3 commits intov0.34.xfrom
mergify/bp/v0.34.x/pr-9371

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 3, 2022

This is an automatic backport of pull request #9371 done by Mergify.
Cherry-pick of d764562 has failed:

On branch mergify/bp/v0.34.x/pr-9371
Your branch is up to date with 'origin/v0.34.x'.

You are currently cherry-picking commit d7645628f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .goreleaser.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…ses (#9371)

This is by no means a signal that we offer any additional guarantees with our software. This warning seems somewhat pointless given that:
1. Our open source license clearly states that we offer no warranties with this software.
2. We are clearly still pre-1.0.

It also doesn't make sense to append "(WARNING: BETA SOFTWARE)" to pre-releases such as alpha releases, which are to be considered _more_ unstable than beta releases.

---

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed

(cherry picked from commit d764562)

# Conflicts:
#	.goreleaser.yml
@mergify mergify bot requested a review from ebuchman as a code owner September 3, 2022 14:59
@mergify mergify bot requested a review from a team September 3, 2022 14:59
@mergify mergify bot added the conflicts label Sep 3, 2022
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>

release:
<<<<<<< HEAD
name_template: "{{.Version}} (WARNING: BETA SOFTWARE)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only hunk in the original PR (#9371). Are the changes shown below intended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were intended. It's not 100% clear to me whether Goreleaser will be archiving the root docs on the release branch (i.e. v0.34.x) when cutting new patch releases, or the docs on main, so I thought I'd use this opportunity to sync the two sets of docs.

See https://github.com/tendermint/tendermint/pull/9373/files#diff-42e26dc67aed8aa3edb2472b4403288c1699fb6dc47419b9a475f0f224fe4689R31

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@thanethomson thanethomson merged commit 441405e into v0.34.x Sep 5, 2022
@thanethomson thanethomson deleted the mergify/bp/v0.34.x/pr-9371 branch September 5, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants