Skip to content

consensus: backport abci and consensus metrics #9273

Merged
williambanfield merged 5 commits intofeature/abci++pppfrom
wb/backport-metrics
Aug 17, 2022
Merged

consensus: backport abci and consensus metrics #9273
williambanfield merged 5 commits intofeature/abci++pppfrom
wb/backport-metrics

Conversation

@williambanfield
Copy link
Contributor

Partially backports #8480
Part of #9053

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

williambanfield and others added 3 commits August 16, 2022 18:53
This pull request adds an additional set of metrics targeted at providing more visibility into `abci++`.

The following set of metrics are added and exposed through the `metrics` endpoint:

```
tendermint_consensus_proposal_receive_count{chain_id="test-chain-IrF74Y",status="accepted"} 34
tendermint_consensus_proposal_create_count{chain_id="test-chain-IrF74Y"} 34
tendermint_consensus_vote_extension_receive_count{chain_id="test-chain-IrF74Y",status="accepted"} 34
tendermint_consensus_round_voting_power_percent{chain_id="test-chain-IrF74Y",vote_type="precommit"} 1
tendermint_consensus_round_voting_power_percent{chain_id="test-chain-IrF74Y",vote_type="prevote"} 1
tendermint_state_consensus_param_updates{chain_id="test-chain-IrF74Y"} 0
tendermint_state_validator_set_updates{chain_id="test-chain-IrF74Y"} 0
tendermint_consensus_late_votes{chain_id="test-chain-IrF74Y",vote_type="precommit"} 16
```

This pull request also updates the `metrics.md` file to include some metrics that were previously missed. My hope is to generate the `metrics.md` file with a future version of the tool being architected in #8479
@williambanfield williambanfield marked this pull request as ready for review August 16, 2022 22:59
@williambanfield williambanfield requested a review from a team August 16, 2022 22:59
@williambanfield williambanfield merged commit 7bd86ec into feature/abci++ppp Aug 17, 2022
@williambanfield williambanfield deleted the wb/backport-metrics branch August 17, 2022 13:37
@williambanfield williambanfield restored the wb/backport-metrics branch September 9, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants