docs: Update v0.34.x to prepare for v0.37#9244
Conversation
a9303be to
d06ae0f
Compare
|
I think we just need to be ready to watch this deploy and revert quickly if it breaks |
d06ae0f to
115c672
Compare
cason
left a comment
There was a problem hiding this comment.
I was just wondering whether providing links of the format https://docs.tendermint.com/main/something is a good idea.
I think the links should be on the format ttps://docs.tendermint.com/something, so we have the freedom to redirect them to the full path of our preference.
docs/DOCS_README.md
Outdated
| The documentation for Tendermint Core is hosted at: | ||
|
|
||
| - <https://docs.tendermint.com/master/> | ||
| - <https://docs.tendermint.com/main/> |
There was a problem hiding this comment.
This is a broken link now. The link ending with master works.
But should we consider docs.tendermint.com without master or main at the end as the host of the main documentation?
There was a problem hiding this comment.
The link will work once we merge #9243.
https://docs.tendermint.com/ automatically shows the latest stable docs (in our case, right now it shows the v0.34 docs).
|
|
||
|
|
||
| > TIP: Find the RPC Documentation [here](https://docs.tendermint.com/master/rpc/) | ||
| > TIP: Find the RPC Documentation [here](https://docs.tendermint.com/main/rpc/) |
There was a problem hiding this comment.
It should be nice if https://docs.tendermint.com/rpc/ was the address of this documentation, even though under the hood if redirected to [master/main/latest]/rpc/
There was a problem hiding this comment.
It's not clear whether our theme actually supports this right now.
| ws ws://localhost:26657/websocket | ||
| > { "jsonrpc": "2.0", "method": "subscribe", "params": ["tm.event='NewBlock'"], "id": 1 } | ||
| version: "Master" | ||
| version: "v0.34" |
There was a problem hiding this comment.
No, this was incorrectly labelled. Take a look at https://docs.tendermint.com/v0.34/rpc/: the "Master" tag to the top-right of the "Tendermint RPC" heading should actually read "v0.34", because it's the OpenAPI spec for v0.34.
This is mostly a cosmetic thing, but I think it's important we label things correctly.
07794f6 to
2bfbb98
Compare
2bfbb98 to
0f46adb
Compare
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
0f46adb to
82c109c
Compare
Partially addresses #9096.
Similar to #9243, but targets the
v0.34.xbranch.PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed