Remove obsolete abci methods, no longer called by ABCI++ Tendermint#8633
Remove obsolete abci methods, no longer called by ABCI++ Tendermint#8633sergio-mena merged 10 commits intomasterfrom
Conversation
|
The reasoning here makes sense, but I wonder: Do we need to worry about being able to read stored responses in order to validate old blocks? I seem to recall we do rely on some of the ABCI response data being persisted in order to deal with synchronization. |
tychoish
left a comment
There was a problem hiding this comment.
seems good but fix lint
Are you thinking of The rest of the protobuf data structures deleted in this PR are just not used elsewhere in the "manually generated" code. |
Yes, and I wasn't sure if there were others. |
At a first stage, we had decided to leave
BeginBlock,DeliverTx,EndBlockin the ".proto" file, marked as deprecated. However, since Tendermint will not be calling them, an App developer might be tempted to implement them, which would result in dead code.This PR removes those ABCI methods from the ".proto" file.
The PR also adds a link to ABCI++ spec in the "UPGRADING.md" file, as a preliminary step to documenting the upgrade process.