Skip to content

blocksync: verification rework- part 1#8419

Closed
jmalicevic wants to merge 57 commits intomasterfrom
jasmina/4457-blocksync-verification_part1
Closed

blocksync: verification rework- part 1#8419
jmalicevic wants to merge 57 commits intomasterfrom
jasmina/4457-blocksync-verification_part1

Conversation

@jmalicevic
Copy link
Contributor

@jmalicevic jmalicevic commented Apr 26, 2022

Closes #4457

The blocksync verification now resembles the verification done by the light client (without witness verification and relying on a trusted period).

  • We start from a trusted state at height H. If the LastCommit of the block at height H+1 does not verify block at H, we can dismiss the block at H+1. If it does, we use the LastCommit of the block at H+2 to verify the block at H+1. The validator set of the LastCommit at block H+2 is verified against the NextValidators stored in the trusted state (at height H).

jmalicevic added 11 commits April 7, 2022 14:25
@jmalicevic
blocksync: Initial working commit with adjacent block verification
09f522b 
store: Added functions ot return protobuf objects for block and commit (perf opt)
proto: Added Commit to the BlockResponse message

- WARN: Manual proto files for blocksync
@jmalicevic
Merge remote-tracking branch 'origin' into jasmina/4457_block_sync_ve…
07fac4c 
…rification
@jmalicevic
Merged with master
4ba3892
@jmalicevic
blocksync: Verification using LastCommit of block at height H + 2
60eaa83
@jmalicevic
Merge remote-tracking branch 'origin/master' into jasmina/4457_block_…
a6e0813 
…sync_verification
@jmalicevic
minor delete
b4f422e
@jmalicevic
blocksync: separate verification into different file
d22f4c4
@jmalicevic
Merge remote-tracking branch 'origin/master' into jasmina/4457_block_…
bf31f6f 
…sync_verification
@jmalicevic
reverted proto change
361d631
@jmalicevic
Merge remote-tracking branch 'origin' into jasmina/4457-blocksync-ver…
abfc780 
…ification_part1
@jmalicevic
Removed commented out code
4e6d380
@jmalicevic jmalicevic changed the title (WIP): Blocksync verification - part 1 (WIP)blocksync: verification rework- part 1 Apr 27, 2022
@jmalicevic jmalicevic mentioned this pull request Apr 27, 2022
Closed
@jmalicevic jmalicevic changed the title (WIP)blocksync: verification rework- part 1 blocksync: verification rework- part 1 May 3, 2022
@jmalicevic jmalicevic marked this pull request as ready for review May 3, 2022 13:34
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jun 4, 2022
@jmalicevic jmalicevic removed the stale for use by stalebot label Jun 6, 2022
@cmwaters
Copy link
Contributor

cmwaters commented Jun 8, 2022

This work, I believe, is a little on hold at the moment as the team focus on v0.35 and v0.36 releases. Hopefully we can return to this soon and get it in for v0.37

@github-actions
Copy link

github-actions bot commented Jun 27, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jun 27, 2022
@github-actions github-actions bot closed this Jul 1, 2022
@jmalicevic jmalicevic reopened this Jul 4, 2022
@cmwaters cmwaters removed the stale for use by stalebot label Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 17, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jul 17, 2022
@jmalicevic jmalicevic removed the stale for use by stalebot label Jul 17, 2022
@github-actions
Copy link

github-actions bot commented Jul 28, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jul 28, 2022
@jmalicevic jmalicevic removed the stale for use by stalebot label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Aug 8, 2022
@github-actions github-actions bot closed this Aug 12, 2022
@jmalicevic jmalicevic removed the stale for use by stalebot label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@tychoish tychoish Awaiting requested review from tychoish

@williambanfield williambanfield Awaiting requested review from williambanfield

@creachadair creachadair Awaiting requested review from creachadair

@thanethomson thanethomson Awaiting requested review from thanethomson

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@josef-widder josef-widder Awaiting requested review from josef-widder

@milosevic milosevic Awaiting requested review from milosevic

4 more reviewers

@sergio-mena sergio-mena sergio-mena left review comments

@tac0turtle tac0turtle tac0turtle left review comments

@cmwaters cmwaters cmwaters left review comments

@cason cason cason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Light client verification for fast sync

5 participants

@jmalicevic @cmwaters @cason @sergio-mena @tac0turtle