types: update synchrony params to match checked in proto#8142
Merged
mergify[bot] merged 3 commits intomasterfrom Mar 17, 2022
Merged
types: update synchrony params to match checked in proto#8142mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.protofile do not have thenullable = falseannotation present on theSynchronyParamsdurations. This pull request updates theSynchronyParamsto match the checked in proto files. Note, this does not make the code buildable against the latest protos. This pull request was achieved by checking out all files not relevant to theSynchronyParamsand removing the newTimeoutParamsfrom the theparams.protofile. Future updates will add these back.This pull request also adds a
nilcheck to thepbParams.Synchronyfield inConsensusParamsFromProto. Old versions of Tendermint will not have theSynchronyparameters filled in so this code would panic on startup.We will fill in the empty fields with defaults, but per https://github.com/tendermint/tendermint/blob/master/docs/rfc/rfc-009-consensus-parameter-upgrades.md#only-update-hashedparams-on-hash-breaking-releases we will keep out of the hash during this release.