Skip to content

types: update synchrony params to match checked in proto#8142

Merged
mergify[bot] merged 3 commits intomasterfrom
wb/rebuild-synchrony-params
Mar 17, 2022
Merged

types: update synchrony params to match checked in proto#8142
mergify[bot] merged 3 commits intomasterfrom
wb/rebuild-synchrony-params

Conversation

@williambanfield
Copy link
Contributor

@williambanfield williambanfield commented Mar 16, 2022

The .proto file do not have the nullable = false annotation present on the SynchronyParams durations. This pull request updates the SynchronyParams to match the checked in proto files. Note, this does not make the code buildable against the latest protos. This pull request was achieved by checking out all files not relevant to the SynchronyParams and removing the new TimeoutParams from the the params.proto file. Future updates will add these back.

This pull request also adds a nil check to the pbParams.Synchrony field in ConsensusParamsFromProto. Old versions of Tendermint will not have the Synchrony parameters filled in so this code would panic on startup.

We will fill in the empty fields with defaults, but per https://github.com/tendermint/tendermint/blob/master/docs/rfc/rfc-009-consensus-parameter-upgrades.md#only-update-hashedparams-on-hash-breaking-releases we will keep out of the hash during this release.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants