Skip to content

build(deps): Bump github.com/tendermint/tm-db from 0.6.6 to 0.6.7#7939

Closed
dependabot[bot] wants to merge 2 commits intomasterfrom
dependabot/go_modules/master/github.com/tendermint/tm-db-0.6.7
Closed

build(deps): Bump github.com/tendermint/tm-db from 0.6.6 to 0.6.7#7939
dependabot[bot] wants to merge 2 commits intomasterfrom
dependabot/go_modules/master/github.com/tendermint/tm-db-0.6.7

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 22, 2022

Bumps github.com/tendermint/tm-db from 0.6.6 to 0.6.7.

Release notes

Sourced from github.com/tendermint/tm-db's releases.

Release v0.6.7

https://github.com/tendermint/tm-db/blob/v0.6.7/CHANGELOG.md

Changelog

Sourced from github.com/tendermint/tm-db's changelog.

0.6.7

2022-2-21

  • Use cosmos/rocksdb instead of techbot/rocksdb
  • Add ForceCopmact to goleveldb database
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
build(deps): Bump github.com/tendermint/tm-db from 0.6.6 to 0.6.7
831330a 
Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.6 to 0.6.7.
- [Release notes](https://github.com/tendermint/tm-db/releases)
- [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md)
- [Commits](tendermint/tm-db@v0.6.6...v0.6.7)

---
updated-dependencies:
- dependency-name: github.com/tendermint/tm-db
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added S:automerge Automatically merge PR when requirements pass T:dependencies Pull requests that update a dependency file labels Feb 22, 2022
@creachadair
Copy link

creachadair commented Feb 22, 2022

Hmm. This appears to depend not only on the Go fork, but possibly also a different version of the C library? The builder is failing with cgo resolution errors:

# github.com/cosmos/gorocksdb
Error: /go/pkg/mod/github.com/cosmos/gorocksdb@v1.2.0/transactiondb.go:255:17: could not determine kind of name for C.rocksdb_optimistictransactiondb_checkpoint_object_create
Error: /go/pkg/mod/github.com/cosmos/gorocksdb@v1.2.0/transactiondb.go:208:12: could not determine kind of name for C.rocksdb_optimistictransactiondb_property_value
Error: /go/pkg/mod/github.com/cosmos/gorocksdb@v1.2.0/transactiondb.go:236:2: could not determine kind of name for C.rocksdb_optimistictransactiondb_write
Error: /go/pkg/mod/github.com/cosmos/gorocksdb@v1.2.0/transactiondb.go:59:12: could not determine kind of name for C.rocksdb_transactiondb_property_value

This suggests we would need to also pull a different version of the librocksdb package, but I'm not sure if we have that packaged somewhere.

@creachadair
Copy link

creachadair commented Feb 22, 2022

The problem appears to be limited to the e2e suite, as I think that's the only place where we build with that tag.

@tychoish
Copy link
Contributor

tychoish commented Feb 22, 2022

The problem appears to be limited to the e2e suite, as I think that's the only place where we build with that tag.

Fair, though I think the problem is with tmdb and not with anything intrensic to the e2e suite.

@creachadair
Copy link

creachadair commented Feb 22, 2022

The problem appears to be limited to the e2e suite, as I think that's the only place where we build with that tag.

Fair, though I think the problem is with tmdb and not with anything intrensic to the e2e suite.

Yes, sorry—I don't mean the e2e suite caused the problem, I mean that's where it shows up.

@creachadair creachadair mentioned this pull request Feb 25, 2022
Closed
@creachadair creachadair closed this Mar 2, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 2, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/master/github.com/tendermint/tm-db-0.6.7 branch March 2, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@cmwaters cmwaters Awaiting requested review from cmwaters

@tychoish tychoish Awaiting requested review from tychoish

@williambanfield williambanfield Awaiting requested review from williambanfield

@creachadair creachadair Awaiting requested review from creachadair

Assignees

No one assigned

Labels

S:automerge Automatically merge PR when requirements pass T:dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@creachadair @tychoish