Skip to content

dont catchupReplay on wal if we fast synced#791

Merged
ebuchman merged 1 commit intodevelopfrom
740-no-wal-after-fast-sync
Oct 27, 2017
Merged

dont catchupReplay on wal if we fast synced#791
ebuchman merged 1 commit intodevelopfrom
740-no-wal-after-fast-sync

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Oct 26, 2017

Addresses #740

Not thrilled about it though. Anyone have better ideas?

@ebuchman ebuchman mentioned this pull request Oct 26, 2017
Closed
@melekes
Copy link
Contributor

melekes commented Oct 27, 2017

Tests failed with:

consensus/byzantine_test.go:104:32: not enough arguments in call to byzR.reactor.SwitchToConsensus
        have (*state.State)
        want (*state.State, int)
consensus/byzantine_test.go:107:23: not enough arguments in call to cr.SwitchToConsensus
        have (*state.State)
        want (*state.State, int)
consensus/reactor_test.go:57:32: not enough arguments in call to reactors[i].SwitchToConsensus
        have (*state.State)
        want (*state.State, int)

@ebuchman ebuchman force-pushed the 740-no-wal-after-fast-sync branch from a2c1de3 to 591dd9e Compare October 27, 2017 14:46
@ebuchman
Copy link
Contributor Author

ebuchman commented Oct 27, 2017

Woops pushed some other blockchain pkg changes in there. But think its fine

@ebuchman ebuchman merged commit 3319ad0 into develop Oct 27, 2017
@zramsay zramsay deleted the 740-no-wal-after-fast-sync branch October 27, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ebuchman @melekes