types: make timely predicate adaptive after 10 rounds#7739
Merged
mergify[bot] merged 7 commits intomasterfrom Feb 2, 2022
Merged
types: make timely predicate adaptive after 10 rounds#7739mergify[bot] merged 7 commits intomasterfrom
mergify[bot] merged 7 commits intomasterfrom
Conversation
tychoish
approved these changes
Jan 31, 2022
williambanfield
commented
Jan 31, 2022
creachadair
approved these changes
Jan 31, 2022
e7171be to
44fbb9c
Compare
creachadair
reviewed
Feb 2, 2022
cason
reviewed
Feb 7, 2022
| // proceed in the case that the chosen value was too small for the given network conditions. | ||
| // For more information and discussion on this mechanism, see the relevant github issue: | ||
| // https://github.com/tendermint/spec/issues/371 | ||
| maxShift := bits.LeadingZeros64(uint64(sp.MessageDelay)) - 1 |
There was a problem hiding this comment.
This is a closed PR, but I feel that this treatment should be restricted to when the shift is applied, namely round > 10, Don't you think that enclosing this code inside an if would be a better solution?
30 tasks
1 task
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds logic to double the message delay bound after every 10 rounds. Alternatives to this somewhat magic number were discussed. Specifically, whether or not to make '10' modifiable as a parameter was discussed. Since this behavior only exists to ensure liveness in the case that these values were poorly chosen to begin with, a method to configure this value was not created. Chains that notice many 'untimely' rounds per the relevant metric are expected to take action to increase the configured message delay to more accurately match the conditions of the network.
closes: tendermint/spec#371