statesync and blocksync: remove tests for serialized bytes#7383
Closed
williambanfield wants to merge 1 commit intomasterfrom
Closed
statesync and blocksync: remove tests for serialized bytes#7383williambanfield wants to merge 1 commit intomasterfrom
williambanfield wants to merge 1 commit intomasterfrom
Conversation
creachadair
approved these changes
Dec 6, 2021
tac0turtle
approved these changes
Dec 6, 2021
tychoish
approved these changes
Dec 7, 2021
Contributor
Author
|
Closing for now while strategizing on a better way to handle canonical byte ordering for proto serialization when used for hashing / cryptographic signatures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are checking that the serialized bytes of the proto messages do not change. However, the protobuf encoders do not make guarantees about the byte ordering of serialized messages. Namely, the fields may appear in any order in the serialized output.