consensus: ensure proposal receipt waits for maxWaitingTime#7307
Merged
williambanfield merged 6 commits intowb/proposer-based-timestampsfrom Nov 30, 2021
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the Propose Step Timeout changes described in ADR 71.
This code change implements this by taking the max of the recently added
proposalStepWaitingTime(...)method and the configuredtimeout-proposevalue and changes the scheduled RoundStepPropose timeout to occur after this maximum waiting time.This change also adds a small test harness for the ongoing proposer-based timestamp work. The test harness, aims to make it easier to write tests for the pbts timing logic. The first test cases that are added ensure that the consensus algorithm correctly prevotes nil when no block is delivered by the
waitingTimeand ensure that the consensus mechanism prevotes the block if it is delivered beforewaitingTimehas elapsed but aftertimeout-proposehas elapsed.related to: #6942