blocksync/v2: remove unsupported reactor#7046
blocksync/v2: remove unsupported reactor#7046mergify[bot] merged 11 commits intotendermint:masterfrom
Conversation
creachadair
left a comment
There was a problem hiding this comment.
Only one request, otherwise I am excited about this change.
This script is referenced from the release documentation, we should make sure it's functional. This is helpful in generating the "Special Thanks" section of the changelog.
|
This should probably have a changelog entry. Also a question for the team (@tychoish, @creachadair, @williambanfield): do you think it's clearer if we were to structure the repo as if there never were multiple versions (same can be said for mempool or PEX). I.e. can we just have |
| that is battle-tested, but whose test coverage is lacking and is not | ||
| formally verified. |
There was a problem hiding this comment.
Do we have an outstanding issue for this just so we don't forget to increase test coverage at some latter point. It would be great if we could have a more confident message for our users :)
|
It's my intention, heretofore unstated, to flatten the versioned paths as we remove the legacy components. |
Agreed, this is a good idea. |
This commit should be one of the first to land as part of the v0.36
cycle after cutting the 0.35 branch.
The blocksync/v2 reactor was originally implemented as an experiement
to produce an implementation of the blockstack protocol that would be
easier to test and validate, but it was never appropriately
operationalized and this implementation was never fully debugged. When
the p2p layer was refactored as part of the 0.35 cycle, the v2
implementation was not refactored and it was left in the codebase but
not removed. This commit just removes all references to it.