tools: add mockery to tools.go and remove mockery version strings#6787
Merged
mergify[bot] merged 1 commit intomasterfrom Jul 30, 2021
Merged
tools: add mockery to tools.go and remove mockery version strings#6787mergify[bot] merged 1 commit intomasterfrom
mergify[bot] merged 1 commit intomasterfrom
Conversation
tychoish
approved these changes
Jul 30, 2021
ec8f58a to
ef12f0b
Compare
alexanderbez
approved these changes
Jul 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #6787 +/- ##
==========================================
- Coverage 62.62% 62.58% -0.04%
==========================================
Files 306 306
Lines 40385 40385
==========================================
- Hits 25290 25274 -16
- Misses 13321 13339 +18
+ Partials 1774 1772 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to keep versions of mockery consistent across developer laptops.
This change adds mockery to the
tools.gofile so that its version can be managed consistently in thego.modfile.Additionally, this change temporarily disables adding mockery's version number to generated files. There is an outstanding issue against the mockery project related to the version string behavior when running from
go get. I have created a pull request to fix this issue in the mockery project.see: vektra/mockery#397