light: correctly handle contexts (backport -> v0.34.x)#6685
Merged
light: correctly handle contexts (backport -> v0.34.x)#6685
Conversation
tac0turtle
reviewed
Jul 9, 2021
tychoish
approved these changes
Jul 9, 2021
Codecov Report
@@ Coverage Diff @@
## v0.34.x #6685 +/- ##
==========================================
Coverage ? 60.52%
==========================================
Files ? 265
Lines ? 24323
Branches ? 0
==========================================
Hits ? 14721
Misses ? 8070
Partials ? 1532 |
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows cancelling contexts or using deadlines to actually work. When state sync was using the light client there were occasions where getting the AppHash was taking longer than 10 seconds and so the deadline was getting exceeded but because the light client didn't handle this error properly, it would actually get stuck.