fastsync: update the metrics during fast-sync#6590
Merged
mergify[bot] merged 7 commits intotendermint:masterfrom Jun 23, 2021
Merged
fastsync: update the metrics during fast-sync#6590mergify[bot] merged 7 commits intotendermint:masterfrom
mergify[bot] merged 7 commits intotendermint:masterfrom
Conversation
tychoish
suggested changes
Jun 16, 2021
tychoish
approved these changes
Jun 16, 2021
tac0turtle
reviewed
Jun 17, 2021
tac0turtle
reviewed
Jun 17, 2021
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
I think this is fine for now, Im not the biggest fan of passing the consensus state as we are doing.
This made me think that there may be some metrics that other reactors may want to touch, does it make sense to have node pkg metrics that various reactors can update depending on the various states of a node?
alexanderbez
suggested changes
Jun 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #6590 +/- ##
==========================================
+ Coverage 61.04% 61.07% +0.02%
==========================================
Files 295 295
Lines 27968 27956 -12
==========================================
Hits 17074 17074
+ Misses 9166 9157 -9
+ Partials 1728 1725 -3
|
alexanderbez
approved these changes
Jun 17, 2021
db73170 to
8ef165a
Compare
8ef165a to
f0b0655
Compare
tac0turtle
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3507