Skip to content

metrics: change blocksize to a histogram#6549

Merged
mergify[bot] merged 3 commits intomasterfrom
5752_histogram
Jun 8, 2021
Merged

metrics: change blocksize to a histogram#6549
mergify[bot] merged 3 commits intomasterfrom
5752_histogram

Conversation

@tac0turtle
Copy link
Contributor

Description

Change block_size gauge to a histogram to observe block size overtime

This will help will see which chains have full blocks vs empty.

closes #5752

@tac0turtle tac0turtle added C:consensus Component: Consensus T:observability Type: Observability T:ux Type: Issue or Pull Request related to developer experience labels Jun 8, 2021
@tac0turtle tac0turtle self-assigned this Jun 8, 2021
@tac0turtle tac0turtle marked this pull request as ready for review June 8, 2021 09:36
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #6549 (6212ace) into master (a855f96) will decrease coverage by 0.50%.
The diff coverage is 66.66%.

❗ Current head 6212ace differs from pull request most recent head 46c6b53. Consider uploading reports for the commit 46c6b53 to get more accurate results

@@            Coverage Diff             @@
##           master    #6549      +/-   ##
==========================================
- Coverage   60.96%   60.46%   -0.51%     
==========================================
  Files         293      294       +1     
  Lines       27435    27703     +268     
==========================================
+ Hits        16727    16750      +23     
- Misses       9011     9247     +236     
- Partials     1697     1706       +9     
Impacted Files Coverage Δ
consensus/metrics.go 14.59% <50.00%> (ø)
consensus/state.go 66.96% <100.00%> (ø)
privval/signer_endpoint.go 75.75% <0.00%> (-3.04%) ⬇️
privval/signer_listener_endpoint.go 87.05% <0.00%> (-2.36%) ⬇️
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
crypto/secp256k1/secp256k1.go 71.11% <0.00%> (ø)
cmd/tendermint/commands/replay.go 0.00% <0.00%> (ø)
internal/p2p/pex/errors.go
internal/p2p/trust/store.go
internal/blockchain/v2/types.go
... and 163 more

@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jun 8, 2021
@mergify mergify bot merged commit 2f61416 into master Jun 8, 2021
@mergify mergify bot deleted the 5752_histogram branch June 8, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:consensus Component: Consensus S:automerge Automatically merge PR when requirements pass T:observability Type: Observability T:ux Type: Issue or Pull Request related to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve metric consensus_block_size_bytes

2 participants