state: move pruneBlocks from consensus/state to state/execution#6541
Merged
mergify[bot] merged 4 commits intotendermint:masterfrom Jun 10, 2021
Merged
state: move pruneBlocks from consensus/state to state/execution#6541mergify[bot] merged 4 commits intotendermint:masterfrom
mergify[bot] merged 4 commits intotendermint:masterfrom
Conversation
cmwaters
approved these changes
Jun 7, 2021
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this @JayT106 👍
Looking at this, it seems that we've changed the behaviour of fast sync. Prior it seems like there was no pruning whilst fast syncing but it looks like now there will be. I believe that's fine 🤔
alexanderbez
approved these changes
Jun 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #6541 +/- ##
==========================================
- Coverage 61.08% 61.04% -0.04%
==========================================
Files 295 295
Lines 27850 27848 -2
==========================================
- Hits 17011 17000 -11
- Misses 9124 9130 +6
- Partials 1715 1718 +3
|
596d3f1 to
544b55a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
state: move pruneBlocks function from consensus/state to state/execution
Closes #5414