Remove reliance on default Signer#641
Merged
adrianbrink merged 1 commit intotendermint:feature/hsmfrom Sep 1, 2017
thales-e-security:fix-default-signer
Merged
Remove reliance on default Signer#641adrianbrink merged 1 commit intotendermint:feature/hsmfrom thales-e-security:fix-default-signer
adrianbrink merged 1 commit intotendermint:feature/hsmfrom
thales-e-security:fix-default-signer
Conversation
This change allows the default privValidator to use a custom Signer implementation with no reliance on the default Signer implementation.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the default privValidator to use a custom Signer implementation with no reliance on the default Signer implementation.
Due to the existing naming of methods (and not wishing to break backwards compatibility), the downside of my change is that we lose logging information. There was no natural place to insert a logger object.