tests: Fix TestByzantinePrevoteEquivocation#6132
Merged
mergify[bot] merged 2 commits intomasterfrom Feb 18, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6132 +/- ##
==========================================
+ Coverage 60.65% 60.88% +0.23%
==========================================
Files 276 276
Lines 25646 25649 +3
==========================================
+ Hits 15555 15616 +61
+ Misses 8469 8407 -62
- Partials 1622 1626 +4
|
melekes
approved these changes
Feb 18, 2021
| // different to the timestamp that the other nodes have. This tests to ensure | ||
| // that the evidence that finally gets proposed will have a valid timestamp. | ||
| lazyProposer := states[1] | ||
| // lazyProposer := states[1] |
Contributor
There was a problem hiding this comment.
Suggested change
| // lazyProposer := states[1] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed setting the buffer size on the subscription. Note, this doesn't really "fix" this test (a la ref: #5710).
However, I spent a good chunk of time looking at this test with many logs and I'm pretty sure this is mainly due to the fact that none of the nodes get the conflicting vote in time.
closes: #6127