state: save in batches within the state store#6067
state: save in batches within the state store#6067cmwaters merged 7 commits intotendermint:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6067 +/- ##
==========================================
- Coverage 60.74% 60.64% -0.11%
==========================================
Files 276 276
Lines 25709 25715 +6
==========================================
- Hits 15618 15594 -24
- Misses 8476 8501 +25
- Partials 1615 1620 +5
|
|
This pull request introduces 3 alerts when merging b88bd2d into 38c5d28 - view on LGTM.com new alerts:
|
* saving abciresponses, validators, and consensus rules for now
|
@cmwaters anyway to run all these tests locally? Specifically those like |
|
This pull request introduces 1 alert when merging 1f486f5 into 38c5d28 - view on LGTM.com new alerts:
|
|
Yup. The unit tests are pretty easy just The For the e2e tests you need to |
|
@cmwaters thanks mate |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey @githubsands, I see this PR hasn't been touched in a while. I hope you don't mind me taking it over so that we can get it merged. It seems that it's almost finished in any case. Thanks for the contribution :) |
state/store.go
Outdated
| err := store.db.SetSync(key, state.Bytes()) | ||
| if err != nil { | ||
|
|
||
| if err := batch.Set(stateKey, state.Bytes()); err != nil { |
There was a problem hiding this comment.
why stateKey instead of key? Was this a bug?
There was a problem hiding this comment.
Actually we should probably using key to keep consistency. They are the same. It's only because it was accidentally removed in the first commit of this PR and so I re-added it afterwards that it is different
|
@cmwaters thanks was waiting for a new computer to come in |
New issue arised from: #6018 (review)
Within state.store.go:
are now saved using batches.