p2p: tighten up and test PeerManager#6034
Merged
mergify[bot] merged 46 commits intomasterfrom Feb 3, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6034 +/- ##
==========================================
+ Coverage 59.85% 60.55% +0.70%
==========================================
Files 274 276 +2
Lines 25248 25314 +66
==========================================
+ Hits 15112 15329 +217
+ Misses 8520 8370 -150
+ Partials 1616 1615 -1
|
melekes
reviewed
Feb 2, 2021
| m.mtx.Lock() | ||
| defer m.mtx.Unlock() | ||
|
|
||
| peer, _ := m.store.Get(peerID) |
Contributor
There was a problem hiding this comment.
what if there's no peer with such peerID?
Contributor
Author
There was a problem hiding this comment.
It will return the zero value, i.e. 0, as described in the comment.
melekes
approved these changes
Feb 3, 2021
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tightens up the
PeerManagerand related code, adds a ton of tests, and fixes a bunch of inconsistencies and bugs.