Skip to content

p2p: tighten up and test Transport API#6020

Merged
mergify[bot] merged 20 commits intomasterfrom
erik/transport-tests
Feb 1, 2021
Merged

p2p: tighten up and test Transport API#6020
mergify[bot] merged 20 commits intomasterfrom
erik/transport-tests

Conversation

@erikgrinaker
Copy link
Contributor

This tightens up the new P2P Transport API and infrastructure, fixes a bunch of bugs and inconsistencies, and adds tests.

@erikgrinaker erikgrinaker added C:p2p Component: P2P pkg S:automerge Automatically merge PR when requirements pass labels Jan 31, 2021
@erikgrinaker erikgrinaker self-assigned this Jan 31, 2021
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #6020 (380b7ca) into master (50b8907) will increase coverage by 0.36%.
The diff coverage is 84.83%.

@@            Coverage Diff             @@
##           master    #6020      +/-   ##
==========================================
+ Coverage   59.15%   59.52%   +0.36%     
==========================================
  Files         273      273              
  Lines       25229    25240      +11     
==========================================
+ Hits        14924    15023      +99     
+ Misses       8681     8596      -85     
+ Partials     1624     1621       -3     
Impacted Files Coverage Δ
p2p/transport_mconn.go 83.66% <79.26%> (+35.04%) ⬆️
p2p/transport_memory.go 83.56% <85.48%> (+11.58%) ⬆️
p2p/peer.go 45.37% <95.23%> (+1.13%) ⬆️
p2p/key.go 75.00% <100.00%> (+3.57%) ⬆️
p2p/router.go 58.88% <100.00%> (ø)
p2p/switch.go 62.29% <100.00%> (+2.01%) ⬆️
p2p/transport.go 100.00% <100.00%> (+54.16%) ⬆️
privval/signer_server.go 89.47% <0.00%> (-10.53%) ⬇️
privval/signer_listener_endpoint.go 80.00% <0.00%> (-9.42%) ⬇️
privval/signer_endpoint.go 75.75% <0.00%> (-9.10%) ⬇️
... and 16 more

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 1f39f80 into master Feb 1, 2021
@mergify mergify bot deleted the erik/transport-tests branch February 1, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:p2p Component: P2P pkg S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants