Merged
Conversation
…dermint into marko/remove-iota
Codecov Report
@@ Coverage Diff @@
## master #5987 +/- ##
==========================================
- Coverage 59.57% 59.49% -0.08%
==========================================
Files 272 272
Lines 25231 25210 -21
==========================================
- Hits 15031 14999 -32
- Misses 8587 8593 +6
- Partials 1613 1618 +5
|
melekes
reviewed
Jan 28, 2021
cmwaters
approved these changes
Jan 28, 2021
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Good stuff 👍 It might also be a good idea to append this PR id to the existing changelog entry regarding removing timeIota so that people can find this one as well.
melekes
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #5939