Conversation
…int/tendermint into bez/p2p-refactor-mempool-reactor
Codecov Report
@@ Coverage Diff @@
## master #5919 +/- ##
==========================================
- Coverage 59.95% 59.80% -0.15%
==========================================
Files 270 271 +1
Lines 24696 24890 +194
==========================================
+ Hits 14806 14886 +80
- Misses 8285 8387 +102
- Partials 1605 1617 +12
|
| // should be used in cases where guarantees cannot be made about when and how | ||
| // many times closure is executed. | ||
| type Closer struct { | ||
| closeOnce deadlock.Once |
There was a problem hiding this comment.
Too bad that we have to duplicate all of the code just for this import. Would it be possible to have two files which set the type as a variable or something?
There was a problem hiding this comment.
Not sure I follow? Is there an easier approach when build flags are involved?
There was a problem hiding this comment.
I was thinking we could use an interface or something, and just do e.g. var Once OnceInterface = deadlock.Once, and same in a different file with sync.Once. However, turns out deadlock.Once doesn't do anything so we can just move it to a separate file and not use deadlock.Once at all.
https://github.com/sasha-s/go-deadlock/blob/1595213edefa28ca5047b00340c63557f9c051d0/deadlock.go#L58
|
Looks like the E2E tests are failing here btw. |
Yes, because I missed adding an explicit |
Description
Prepares the mempool reactor for the newly designed p2p changes per ADR 062.
ref: #5670