Conversation
|
This pull request introduces 1 alert when merging c1dcb23 into e13b438 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5725 +/- ##
==========================================
- Coverage 60.10% 59.90% -0.20%
==========================================
Files 263 267 +4
Lines 23938 24094 +156
==========================================
+ Hits 14387 14433 +46
- Misses 8018 8126 +108
- Partials 1533 1535 +2
|
|
Marking as r4r, the outstanding item is to integrate into e2e. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
|
| return nil, status.Errorf(codes.InvalidArgument, "error signing vote: %v", err) | ||
| } | ||
|
|
||
| ss.logger.Info("SignerServer: SignVote Success") |
There was a problem hiding this comment.
do we want to print some details here? like vote's hash or something?
There was a problem hiding this comment.
Not sure that brings any value to someone using this. Personally I'd consider it noise to have hashes of vote, proposal and various other things in the Info log.
There was a problem hiding this comment.
u mean operators don't need to see what they're signing? okay
There was a problem hiding this comment.
Could you explain why someone would want to use it? I can't see a reason, but could be missing something. For me I wouldn't know what do with the outputted hash.
I can add a debug with hashes and other information.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
todo:
Closes: #4698
Closes: #3885