Backport v0.34.0-rc7: #5661#5669
Merged
alexanderbez merged 4 commits intorc7/v0.34.0from Nov 16, 2020
Merged
Conversation
tac0turtle
approved these changes
Nov 16, 2020
Codecov Report
@@ Coverage Diff @@
## rc7/v0.34.0 #5669 +/- ##
==============================================
Coverage ? 60.50%
==============================================
Files ? 263
Lines ? 23795
Branches ? 0
==============================================
Hits ? 14397
Misses ? 7916
Partials ? 1482 |
Contributor
|
Looks like we forgot to clear out |
Contributor
Author
|
@erikgrinaker mind if I just do that in this PR? Or does |
Contributor
|
Personally I'd prefer a separate PR, but I don't think it matters in this case since we're never going to be cherry-picking any of these changes anywhere else. Nothing needs to change on |
Contributor
Author
|
Updated @erikgrinaker |
erikgrinaker
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #5661 to v0.34.0-rc7.
/cc @tessr