Skip to content

ci: use gh pages#5609

Merged
tac0turtle merged 8 commits intomasterfrom
marko/ci_docs
Nov 3, 2020
Merged

ci: use gh pages#5609
tac0turtle merged 8 commits intomasterfrom
marko/ci_docs

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Nov 2, 2020

Description

  • removes last pieces of circle ci
  • migrates to using github pages.

Pre-merge:

  • enable gh-pages on the repo
  • set it to look for index.html
  • test deployment
  • remove circle

Post-merge

  • get in touch with AiB about proxying tendermint.github.io/tendermint/master to docs.tendermint.com

Closes: #5478

DEMO:

@tac0turtle tac0turtle added the C:docs Component: Documentation label Nov 2, 2020
@tac0turtle tac0turtle self-assigned this Nov 2, 2020
@tac0turtle tac0turtle marked this pull request as ready for review November 3, 2020 10:24
@tac0turtle tac0turtle requested review from alessio and fadeev November 3, 2020 10:25
@tac0turtle
Copy link
Contributor Author

Post-merge

*  get in touch with AiB about proxying tendermint.github.io/tendermint/master to docs.tendermint.com

@alessio I need some help with this stage. Do you know how the tendermint domain is managed?

Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love seeing .circleci/config.yml go! 🎉

@alessio
Copy link
Contributor

alessio commented Nov 3, 2020

Thanks for the great work @marbar3778, greatly appreciated.

We can't work on this yet because we're experiencing a few issues with our DNS configuration. Rest assured that as soon as we get those issues sorted, we'll implement the required changes.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tac0turtle
Copy link
Contributor Author

We can't work on this yet because we're experiencing a few issues with our DNS configuration. Rest assured that as soon as we get those issues sorted, we'll implement the required changes.

Should I keep the circleci deployment?

@tac0turtle
Copy link
Contributor Author

Got so close to removing circleci, but we have to keep it till DNS is resolved.

@tac0turtle tac0turtle merged commit 0e9798f into master Nov 3, 2020
@tac0turtle tac0turtle deleted the marko/ci_docs branch November 3, 2020 17:37
@alessio
Copy link
Contributor

alessio commented Nov 24, 2020

@helder-moreira am I right in thinking that we are now in the position to work on this?

@helder-moreira
Copy link

@alessio you are right. I am on it. Is this the only reason why we still have circle CI here?

@tac0turtle
Copy link
Contributor Author

I can remove it now. Was waiting on this migration to happen first

@helder-moreira
Copy link

@marbar3778 you can do it. I have already changed DNS. Should be ready in a few minutes. I will also remove old AWS Cloudfront deployment after this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:docs Component: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

circleci -> github actions migration

5 participants