Skip to content

docs: tweak v0.33 version#5424

Closed
lovincyrus wants to merge 2 commits intov0.33from
cyrus/0.33-version
Closed

docs: tweak v0.33 version#5424
lovincyrus wants to merge 2 commits intov0.33from
cyrus/0.33-version

Conversation

@lovincyrus
Copy link
Contributor

Description

Refer to #5409 (comment)

  • fix build errors

@lovincyrus lovincyrus added the C:docs Component: Documentation label Sep 29, 2020
@lovincyrus lovincyrus mentioned this pull request Sep 29, 2020
3 tasks
@tac0turtle
Copy link
Contributor

Hmm not sure we should be doing this, before we merge I need to check the release process because ci watches for branches merged into vX.X branches

@lovincyrus
Copy link
Contributor Author

Hmm not sure we should be doing this, before we merge I need to check the release process because ci watches for branches merged into vX.X branches

Can we make this work? Otherwise, the JS build error on v0.33 persists. Therefore, the versions approach won't work.

https://github.com/tendermint/tendermint/blob/master/.circleci/config.yml#L105 is pulling versioned content from git branches. So that shouldn't be a problem.

@tac0turtle
Copy link
Contributor

Can we make this work? Otherwise, the JS build error on v0.33 persists. Therefore, the versions approach won't work.

https://github.com/tendermint/tendermint/blob/master/.circleci/config.yml#L105 is pulling versioned content from git branches. So that shouldn't be a problem.

The simplest fix would be to use your branch instead of 0.33. I think this is fine for now till we get the sidebar fix you have in a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:docs Component: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants