state: more test cases for block validation#5415
Merged
mergify[bot] merged 3 commits intomasterfrom Sep 28, 2020
Merged
Conversation
erikgrinaker
approved these changes
Sep 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
+ Coverage 60.83% 61.35% +0.51%
==========================================
Files 203 259 +56
Lines 20526 23429 +2903
==========================================
+ Hits 12488 14375 +1887
- Misses 6961 7602 +641
- Partials 1077 1452 +375
|
cmwaters
reviewed
Sep 28, 2020
| len(block.ProposerAddress), | ||
| ) | ||
| } | ||
| // The length is checked in ValidateBasic above. |
Contributor
There was a problem hiding this comment.
I think it's probably better just to remove all commenting regarding checking the length of the proposer especially as this directly proceeds checking if the proposer is part of the current validator set. I feel like it might just be confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2589