config: set time_iota_ms to timeout_commit in test genesis#5386
Merged
config: set time_iota_ms to timeout_commit in test genesis#5386
Conversation
also, document consensus parameters. https://forum.cosmos.network/t/consensus-timeouts-explained/1421 Closes #4489
Codecov Report
@@ Coverage Diff @@
## master #5386 +/- ##
==========================================
- Coverage 61.48% 61.27% -0.22%
==========================================
Files 259 259
Lines 23385 23385
==========================================
- Hits 14379 14328 -51
- Misses 7549 7600 +51
Partials 1457 1457
|
erikgrinaker
approved these changes
Sep 23, 2020
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Thanks for documenting! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also, document consensus parameters.
https://forum.cosmos.network/t/consensus-timeouts-explained/1421
Closes #4489