consensus: don't check InitChain app hash vs genesis app hash, replace it#5237
Merged
mergify[bot] merged 1 commit intomasterfrom Aug 13, 2020
Merged
Conversation
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #5237 +/- ##
==========================================
- Coverage 63.02% 62.50% -0.53%
==========================================
Files 179 259 +80
Lines 18922 27187 +8265
==========================================
+ Hits 11926 16992 +5066
- Misses 6013 8717 +2704
- Partials 983 1478 +495
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #5227. Instead of checking
ResponseInitChain.app_hashagainst the genesis doc app hash, we instead replace it. We should probably remove the genesis doc app hash completely, and rely solely on the one fromInitChain, I'll open a separate issue to discuss this.