Merged
Conversation
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #5165 +/- ##
==========================================
+ Coverage 61.07% 64.87% +3.79%
==========================================
Files 203 197 -6
Lines 20538 19260 -1278
==========================================
- Hits 12544 12495 -49
+ Misses 6920 5604 -1316
- Partials 1074 1161 +87
|
tac0turtle
reviewed
Jul 29, 2020
| @@ -49,9 +49,28 @@ definition](https://github.com/tendermint/tendermint/blob/master/types/genesis.g | |||
| chain IDs, you will have a bad time. The ChainID must be less than 50 symbols. | |||
| - `consensus_params` | |||
Contributor
There was a problem hiding this comment.
a minor note with a link to the consensus params in the spec?
tac0turtle
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2836