Skip to content

docs: simplify choosing an ADR number#5156

Merged
mergify[bot] merged 2 commits intomasterfrom
anton/2313-adr
Jul 27, 2020
Merged

docs: simplify choosing an ADR number#5156
mergify[bot] merged 2 commits intomasterfrom
anton/2313-adr

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Jul 27, 2020

Closes #2313

@melekes melekes requested a review from tessr as a code owner July 27, 2020 11:54
@auto-comment
Copy link

auto-comment bot commented Jul 27, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀


> How to pick a number for the ADR?

Find the largest existing ADR number and bump it by 1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but first we are filling up the empty templates right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is more of the plan how to move forward

@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Jul 27, 2020
@mergify mergify bot merged commit 6f61411 into master Jul 27, 2020
@mergify mergify bot deleted the anton/2313-adr branch July 27, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADR Assignment

3 participants