Skip to content

ADR: add missing numbers as blank templates#5154

Merged
mergify[bot] merged 2 commits intomasterfrom
marko/2313_adr_assignment
Jul 27, 2020
Merged

ADR: add missing numbers as blank templates#5154
mergify[bot] merged 2 commits intomasterfrom
marko/2313_adr_assignment

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Jul 27, 2020

Description

This pr adds missing adr numbers based on what is in #2313

This pr adds empty templates that should later be filled when the time comes to do the implementation.

there are still missing numbers, we can either fill them in when we write more ADRs or not backfill numbers and only go forwards.

Closes: #2313

@auto-comment
Copy link

auto-comment bot commented Jul 27, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle self-assigned this Jul 27, 2020
@tac0turtle tac0turtle marked this pull request as ready for review July 27, 2020 11:48
@tac0turtle tac0turtle requested review from melekes and tessr as code owners July 27, 2020 11:48
@tac0turtle tac0turtle requested a review from erikgrinaker July 27, 2020 11:49
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jul 27, 2020
@mergify mergify bot merged commit 2675b5f into master Jul 27, 2020
@mergify mergify bot deleted the marko/2313_adr_assignment branch July 27, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADR Assignment

2 participants