rpc/core: do not lock ConsensusState mutex#4844
Merged
mergify[bot] merged 5 commits intomasterfrom May 15, 2020
Merged
Conversation
in /validators, /consensus_params and /status Closes #3161
during block execution
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
erikgrinaker
approved these changes
May 15, 2020
rpc/core/env.go
Outdated
| return 0, fmt.Errorf("height %d must be less than or equal to the current blockchain height %d", | ||
| height, currentHeight) | ||
| } | ||
| currentBase := env.BlockStore.Base() |
Contributor
There was a problem hiding this comment.
Why are we passing currentHeight via param but getting currentBase from environment? Shouldn't both be passed via the same mechanism?
Contributor
Author
There was a problem hiding this comment.
because currentHeight differs - it can be latestUncommittedHeight or latest block height. current base stays the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in /validators, /consensus_params and /status
Closes #3161