types: return an error if voting power overflows#4764
Merged
mergify[bot] merged 3 commits intomasterfrom May 4, 2020
Merged
Conversation
in VerifyCommitTrusting Closes #4755
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4764 +/- ##
==========================================
- Coverage 64.59% 64.55% -0.05%
==========================================
Files 216 216
Lines 20104 20104
==========================================
- Hits 12987 12978 -9
- Misses 6075 6083 +8
- Partials 1042 1043 +1
|
tessr
reviewed
Apr 29, 2020
tessr
approved these changes
Apr 29, 2020
Contributor
tessr
left a comment
There was a problem hiding this comment.
Nice. Great test cases too
ebuchman
reviewed
Jun 27, 2020
| absOfB-- | ||
| } | ||
|
|
||
| if (b < 0 && a > 0) || (b < 0 && a < 0) { |
Contributor
There was a problem hiding this comment.
Can't this just be if b < 0 ?
Contributor
Author
There was a problem hiding this comment.
no. b < 0 && a != 0 should work though
ebuchman
reviewed
Jun 27, 2020
| return c | ||
| } | ||
|
|
||
| func safeMul(a, b int64) (int64, bool) { |
Contributor
There was a problem hiding this comment.
Would it not be more efficient to just check that |a| < MaxInt/|b| like for safeAdd?
melekes
added a commit
that referenced
this pull request
Jun 29, 2020
Refs #4764 (comment) also, multiplication via * should be more efficient.
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2020
Refs #4764 (comment) also, multiplication using * should be more efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in VerifyCommitTrusting
Closes #4755