Skip to content

lite2: verify ConsensusHash in rpc client#4693

Merged
mergify[bot] merged 2 commits intomasterfrom
anton/verify-consensus-params
Apr 20, 2020
Merged

lite2: verify ConsensusHash in rpc client#4693
mergify[bot] merged 2 commits intomasterfrom
anton/verify-consensus-params

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Apr 17, 2020


For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@melekes melekes requested a review from tessr as a code owner April 17, 2020 12:10
@erikgrinaker erikgrinaker mentioned this pull request Apr 17, 2020
15 tasks
@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Apr 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #4693 into master will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4693      +/-   ##
==========================================
- Coverage   66.05%   65.88%   -0.17%     
==========================================
  Files         221      221              
  Lines       19834    19843       +9     
==========================================
- Hits        13101    13074      -27     
- Misses       5693     5724      +31     
- Partials     1040     1045       +5     
Impacted Files Coverage Δ
lite2/rpc/client.go 0.00% <0.00%> (ø)
p2p/pex/errors.go 11.11% <0.00%> (-22.23%) ⬇️
libs/events/events.go 93.20% <0.00%> (-4.86%) ⬇️
privval/signer_server.go 91.30% <0.00%> (-4.35%) ⬇️
blockchain/v0/reactor.go 73.04% <0.00%> (-2.61%) ⬇️
p2p/pex/pex_reactor.go 82.17% <0.00%> (-2.23%) ⬇️
blockchain/v0/pool.go 78.02% <0.00%> (-0.64%) ⬇️
consensus/state.go 74.36% <0.00%> (-0.50%) ⬇️
consensus/reactor.go 78.11% <0.00%> (-0.24%) ⬇️
p2p/pex/addrbook.go 70.62% <0.00%> (ø)
... and 4 more

@mergify mergify bot merged commit 26c9134 into master Apr 20, 2020
@mergify mergify bot deleted the anton/verify-consensus-params branch April 20, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants