Conversation
There was a problem hiding this comment.
looks good from the first glance 💛
have you seen the spec https://github.com/tendermint/spec/blob/zm_non-recursive-verification/spec/consensus/light-client/non-recursive-verification.md btw?
Yes, I've had a look at it. The code there seems a little bit bloated but I think my implementation matches it |
# Conflicts: # lite2/client.go
…into callum/non-recursive-bisection
Codecov Report
@@ Coverage Diff @@
## master #4400 +/- ##
==========================================
+ Coverage 65.69% 65.95% +0.25%
==========================================
Files 226 226
Lines 19992 19997 +5
==========================================
+ Hits 13134 13189 +55
+ Misses 5799 5759 -40
+ Partials 1059 1049 -10
|
melekes
left a comment
There was a problem hiding this comment.
We need to write more tests. If I am correct, current code may lead to infinite loops under certain conditions...
since it applies both for sequence and bisection
|
I am going to write tests now. |
of old validator set
closes #4329
As opposed to using recursion to implement the bisection method of verifying a header, which could have problems with memory allocation (especially for smaller devices), the bisection algorithm now uses a for loop.