Merged
Conversation
tessr
reviewed
Jan 28, 2020
fedekunze
reviewed
Jan 28, 2020
tac0turtle
reviewed
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #4352 +/- ##
==========================================
- Coverage 65.7% 65.65% -0.06%
==========================================
Files 225 225
Lines 19771 19771
==========================================
- Hits 12991 12981 -10
- Misses 5752 5759 +7
- Partials 1028 1031 +3
|
tessr
reviewed
Jan 28, 2020
|
|
||
| 2. The node contacts the given seeds to discover peers. | ||
|
|
||
| 3. The node contacts a set of full nodes, and verifies the trusted block header using the given hash via the light client. |
Contributor
There was a problem hiding this comment.
How will we determine which nodes and how many?
Contributor
Author
There was a problem hiding this comment.
That is deliberately underspecified, we'll need further testing while prototyping to determine the optimal number.
melekes
reviewed
Jan 29, 2020
|
|
||
| * Is it possible to reconstruct an identical IAVL tree given separate subtrees in an appropriate order, or is more data needed about the branch structure? | ||
|
|
||
| * Should we punish nodes that provide invalid snapshots? |
Contributor
There was a problem hiding this comment.
What do you mean by punishing? Disconnecting from them should be enough for now.
Contributor
There was a problem hiding this comment.
If the node happens to be a validators, it could be slashed for this, right?
added 19 commits
January 30, 2020 11:29
082b184 to
585478c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft ADR describing a prototype for state sync (see #828).
Updated all relevant documentation in docsUpdated all code comments where relevantWrote testsUpdated CHANGELOG_PENDING.md