Conversation
Closes #3831 The support for rocksdb was added a while back in tendermint/tm-db#12. This commit merely updates the documentation.
tac0turtle
approved these changes
Dec 11, 2019
Contributor
|
Thanks for catching this and updating the docs, @melekes! One thing I wanted to check in on--I believe @marbar3778 had mentioned that the RocksDB integration wasn't fully completed (and we were even talking about removing it until it was more fully requested). Marko, can you catch me up on what you've been thinking there? |
Contributor
|
I believe it is already being used by some teams, mainly some tests are missing but no need to remove it. We recently switched from the fork to the main repo as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3831
The support for rocksdb was added a while back in
tendermint/tm-db#12. This commit merely updates
the documentation.
Updated all relevant documentation in docsWrote tests