Merged
Conversation
- closes #3862 - remove errors file from cmn
melekes
suggested changes
Nov 19, 2019
Contributor
melekes
left a comment
There was a problem hiding this comment.
This needs a CHANGELOG_PENDING.md entry under BREAKING Go API section.
golangcibot
reviewed
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #4157 +/- ##
==========================================
+ Coverage 66.65% 66.65% +<.01%
==========================================
Files 247 246 -1
Lines 21215 21156 -59
==========================================
- Hits 14140 14101 -39
+ Misses 6015 5997 -18
+ Partials 1060 1058 -2
|
melekes
approved these changes
Nov 19, 2019
tessr
reviewed
Nov 19, 2019
Contributor
|
nitpick but when you merge this, can you make the commit is |
Contributor
|
more on that here: https://tip.golang.org/doc/contribute.html#commit_messages the reason for doing this is so that when you're digging through git history and looking at git blame or other git history for a file, everyone can see immediately which package motivated a change. it sounds fastidious but it's actually extremely helpful! |
tessr
approved these changes
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes Remove use of
libs/common/errors.go#3862remove errors file from cmn