Skip to content

Bump grpc dep#4121

Merged
tac0turtle merged 1 commit intomasterfrom
marko/bump-grpc-dep
Nov 8, 2019
Merged

Bump grpc dep#4121
tac0turtle merged 1 commit intomasterfrom
marko/bump-grpc-dep

Conversation

@tac0turtle
Copy link
Contributor

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- bump grpc dep as listed here: #4114

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tessr
Copy link
Contributor

tessr commented Nov 8, 2019

What's the difference between this PR and #4114? Just trying to understand how Dependabot works and how we use it

@tac0turtle
Copy link
Contributor Author

tac0turtle commented Nov 8, 2019

dependabot wasn't able to update go.sum correctly, so all ci was failing, had to jump in manually

it works as intended 98/100 times but sometimes we have to intervene manually

@tessr
Copy link
Contributor

tessr commented Nov 8, 2019

Got it. Thanks for the explanation!

@tac0turtle tac0turtle merged commit cf4360c into master Nov 8, 2019
@tac0turtle tac0turtle deleted the marko/bump-grpc-dep branch November 8, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants