Skip to content

Update signer_dialer_endpoint.go#4115

Merged
melekes merged 6 commits intomasterfrom
unknown repository
Nov 7, 2019
Merged

Update signer_dialer_endpoint.go#4115
melekes merged 6 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Nov 6, 2019

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Added a small function to be able to change the default retry interval for the privval. The default is 100ms, this function allows to change to any time.Duration.

@ghost ghost requested review from ebuchman, melekes and tessr as code owners November 6, 2019 14:05
cosmostuba and others added 2 commits November 6, 2019 14:53
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes
Copy link
Contributor

melekes commented Nov 7, 2019

this needs a CHANGELOG_PENDING.md entry

- [privval] Add `SignerDialerEndpointRetryWaitInterval` option (@cosmostuba)

@melekes melekes merged commit 4b15b96 into tendermint:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant