Skip to content

mempool: moved TxInfo parameter into Mempool.CheckTx()#4083

Merged
melekes merged 4 commits intotendermint:masterfrom
erikgrinaker:issue-3590-checktx-txinfo
Nov 4, 2019
Merged

mempool: moved TxInfo parameter into Mempool.CheckTx()#4083
melekes merged 4 commits intotendermint:masterfrom
erikgrinaker:issue-3590-checktx-txinfo

Conversation

@erikgrinaker
Copy link
Contributor

Fixes #3590. Breaking change.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle tac0turtle added T:breaking Type: Breaking Change R:major PR contains breaking changes that have to wait till a major release is made to be merged C:mempool Component: Mempool R4R labels Oct 27, 2019
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes removed the R:major PR contains breaking changes that have to wait till a major release is made to be merged label Nov 4, 2019
@melekes melekes merged commit 745846b into tendermint:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:mempool Component: Mempool T:breaking Type: Breaking Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mempool: remove CheckTx and force people to use CheckTxWithInfo

3 participants