Skip to content

[Dev Session]: ABCI Overview (2/2)#4044

Merged
melekes merged 3 commits intomasterfrom
dev_ses_abci2
Oct 10, 2019
Merged

[Dev Session]: ABCI Overview (2/2)#4044
melekes merged 3 commits intomasterfrom
dev_ses_abci2

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Oct 8, 2019

PlaceHolder for the upcoming dev session:

if you have any points that you would like covered, please drop a comment 😄

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle tac0turtle added the C:docs Component: Documentation label Oct 8, 2019
@tac0turtle tac0turtle self-assigned this Oct 8, 2019
@tac0turtle tac0turtle changed the title add upcoming dev session [Dev Session]: ABCI Overview (2/2) Oct 8, 2019
@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #4044 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4044      +/-   ##
==========================================
+ Coverage   67.04%   67.05%   +<.01%     
==========================================
  Files         245      245              
  Lines       20590    20590              
==========================================
+ Hits        13805    13806       +1     
+ Misses       5747     5746       -1     
  Partials     1038     1038
Impacted Files Coverage Δ
blockchain/v2/reactor.go 50.87% <0%> (-3.51%) ⬇️
consensus/reactor.go 77.02% <0%> (-0.94%) ⬇️
consensus/state.go 79.31% <0%> (+0.11%) ⬆️
p2p/pex/pex_reactor.go 82.6% <0%> (+0.57%) ⬆️
consensus/replay.go 71.77% <0%> (+0.8%) ⬆️
privval/signer_listener_endpoint.go 89.13% <0%> (+2.17%) ⬆️
privval/signer_endpoint.go 84% <0%> (+5.33%) ⬆️

@tac0turtle tac0turtle marked this pull request as ready for review October 10, 2019 19:17
@melekes melekes merged commit 3e5fa20 into master Oct 10, 2019
@melekes melekes deleted the dev_ses_abci2 branch October 10, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:docs Component: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants