Skip to content

Remove traces of github.com/tendermint/abci#4038

Merged
melekes merged 8 commits intomasterfrom
marko/3648-traces_abci
Oct 7, 2019
Merged

Remove traces of github.com/tendermint/abci#4038
melekes merged 8 commits intomasterfrom
marko/3648-traces_abci

Conversation

@tac0turtle
Copy link
Contributor

  • removed abci dockerfile as it was still referencing github.com/tendermint/abci

closes #3648

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- removed abci dockerfile as it was still referencing `github.com/tendermint/abci`

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #4038 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
+ Coverage   67.13%   67.14%   +<.01%     
==========================================
  Files         245      245              
  Lines       20573    20576       +3     
==========================================
+ Hits        13811    13815       +4     
+ Misses       5726     5724       -2     
- Partials     1036     1037       +1
Impacted Files Coverage Δ
tools/tm-signer-harness/internal/utils.go 33.33% <0%> (-16.67%) ⬇️
blockchain/v2/reactor.go 54.38% <0%> (-15.79%) ⬇️
consensus/reactor.go 78.19% <0%> (ø) ⬆️
consensus/state.go 79.31% <0%> (+0.11%) ⬆️
consensus/replay.go 71.77% <0%> (+0.8%) ⬆️
blockchain/v0/reactor.go 78.77% <0%> (+0.94%) ⬆️
p2p/pex/pex_reactor.go 84.34% <0%> (+1.73%) ⬆️
blockchain/v2/routine.go 81.81% <0%> (+3.03%) ⬆️

@tac0turtle tac0turtle changed the title Remove traces oaf github.com/tendermint/abci Remove traces of github.com/tendermint/abci Oct 7, 2019
@tac0turtle tac0turtle force-pushed the marko/3648-traces_abci branch from 642c9c0 to 55c2aca Compare October 7, 2019 12:33
@tac0turtle tac0turtle force-pushed the marko/3648-traces_abci branch from 55c2aca to 2942f59 Compare October 7, 2019 12:36
@tac0turtle tac0turtle marked this pull request as ready for review October 7, 2019 13:02
@melekes melekes merged commit a13a4b8 into master Oct 7, 2019
@melekes melekes deleted the marko/3648-traces_abci branch October 7, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

abci: Remove traces of github.com/tendermint/abci

3 participants