Skip to content

Cleanup docs#4037

Merged
tac0turtle merged 2 commits intomasterfrom
cleanup_docs
Oct 7, 2019
Merged

Cleanup docs#4037
tac0turtle merged 2 commits intomasterfrom
cleanup_docs

Conversation

@tac0turtle
Copy link
Contributor

  • There were some docs that needed to be removed as they were deprecated or moved

=

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- removed a few files that have been deprecated and/or relocated

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added the C:docs Component: Documentation label Oct 4, 2019
@tac0turtle tac0turtle requested a review from melekes October 4, 2019 13:48
@tac0turtle tac0turtle self-assigned this Oct 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #4037 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4037      +/-   ##
==========================================
- Coverage   67.26%   67.09%   -0.17%     
==========================================
  Files         245      245              
  Lines       20565    20574       +9     
==========================================
- Hits        13833    13805      -28     
- Misses       5704     5733      +29     
- Partials     1028     1036       +8
Impacted Files Coverage Δ
blockchain/v2/reactor.go 54.38% <0%> (-15.79%) ⬇️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
consensus/reactor.go 77.49% <0%> (-1.88%) ⬇️
consensus/state.go 79.31% <0%> (-1.06%) ⬇️
privval/signer_client.go 48.33% <0%> (-0.65%) ⬇️
libs/log/nop_logger.go 0% <0%> (ø) ⬆️
p2p/pex/pex_reactor.go 82.6% <0%> (ø) ⬆️
blockchain/v0/pool.go 80.65% <0%> (+0.65%) ⬆️
privval/signer_endpoint.go 84% <0%> (+2.66%) ⬆️
privval/signer_server.go 100% <0%> (+4.34%) ⬆️

@melekes
Copy link
Contributor

melekes commented Oct 5, 2019

where's ecosystem.json now? tendermint.com still using it I think

@tac0turtle
Copy link
Contributor Author

tac0turtle commented Oct 5, 2019

theres a pr in the tendermint site to remove it from gitignore, so it lives in there now, also for the new site there wont be an ecosystem page...

@tac0turtle tac0turtle merged commit acea49e into master Oct 7, 2019
@tac0turtle tac0turtle deleted the cleanup_docs branch October 7, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:docs Component: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants