Skip to content

Develop -> Master#4022

Merged
melekes merged 2 commits intomasterfrom
4017/doc_develop-master
Sep 27, 2019
Merged

Develop -> Master#4022
melekes merged 2 commits intomasterfrom
4017/doc_develop-master

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Sep 27, 2019 •
edited
Loading

  • Some places still had develop instead of master.

closes #4017

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle
Develop -> Master
0379463 
- Some places still had develop instead of master.

closes #4107

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added the C:docs Component: Documentation label Sep 27, 2019
@tac0turtle tac0turtle requested a review from melekes September 27, 2019 22:00
@tac0turtle tac0turtle self-assigned this Sep 27, 2019
melekes
melekes approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #4022 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4022      +/-   ##
==========================================
- Coverage   67.09%   67.05%   -0.04%     
==========================================
  Files         245      245              
  Lines       20573    20573              
==========================================
- Hits        13803    13795       -8     
- Misses       5737     5741       +4     
- Partials     1033     1037       +4
Impacted Files Coverage Δ
types/tx.go 86.95% <0%> (-4.35%) ⬇️
privval/signer_server.go 95.65% <0%> (-4.35%) ⬇️
consensus/reactor.go 76.43% <0%> (-1.76%) ⬇️
consensus/replay.go 70.96% <0%> (-0.81%) ⬇️
consensus/state.go 78.96% <0%> (-0.59%) ⬇️
p2p/conn/connection.go 80.97% <0%> (+0.25%) ⬆️
p2p/pex/pex_reactor.go 83.18% <0%> (+0.57%) ⬆️
blockchain/v0/pool.go 82.62% <0%> (+1.63%) ⬆️
privval/signer_listener_endpoint.go 89.13% <0%> (+2.17%) ⬆️
privval/signer_endpoint.go 81.33% <0%> (+2.66%) ⬆️
... and 1 more

@melekes melekes merged commit cb1a0a7 into master Sep 27, 2019
@melekes melekes deleted the 4017/doc_develop-master branch September 27, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tac0turtle tac0turtle

Labels

C:docs Component: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation on 'Creating a built-in application in Go' is incomplete

3 participants

@tac0turtle @codecov-io @melekes