Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4010 +/- ##
==========================================
+ Coverage 67.08% 67.24% +0.16%
==========================================
Files 245 245
Lines 20557 20573 +16
==========================================
+ Hits 13790 13835 +45
+ Misses 5730 5709 -21
+ Partials 1037 1029 -8
|
melekes
approved these changes
Sep 22, 2019
consensus/state.go
Outdated
| //cs.Logger.Info("scheduleRound0", "now", tmtime.Now(), "startTime", cs.StartTime) | ||
| sleepDuration := rs.StartTime.Sub(tmtime.Now()) | ||
| cs.scheduleTimeout(sleepDuration, rs.Height, 0, cstypes.RoundStepNewHeight) | ||
| cs.Logger.Error("scheduled timeout commit") |
Contributor
Author
There was a problem hiding this comment.
Whoops lol will remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR summarizing some of the discussion from the Evidence Handling Dev Session.
Conclusion here is to keep evidence handling in Tendermint.
The SDK will still need an evidence module to process evidence from other chains, but evidence for its own should probably be handled by Tendermint.